Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check round result before end tick in tests #121

Closed
wants to merge 2 commits into from

Conversation

SimonAlling
Copy link
Owner

No description provided.

@SimonAlling
Copy link
Owner Author

My plan in #120 was that this PR would make it so that if both expectations (round result and end tick) fail, then both of them are reported. That doesn't seem to be how Expect.all works though – it only shows the first one. WDYT we should do, @lydell?

@SimonAlling SimonAlling changed the title Check round outcome before end tick in tests Check round result before end tick in tests Oct 15, 2024
@SimonAlling
Copy link
Owner Author

So if we can't have the cake and eat it too, then we should ask ourselves: What provides more information: the end tick or the round result? I believe it's the round result. But when trying to figure out why a test is failing, I think it's typically gonna be easier to temporarily change the expected end tick in order to see how the round ends, compared to the other way around.

@SimonAlling SimonAlling deleted the test-outcome-tick branch October 19, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant